Skip to content

Commit

Permalink
mergetool: avoid letting list_tool_variants break user-defined setups
Browse files Browse the repository at this point in the history
In 83bbf9b (mergetool--lib: improve support for vimdiff-style tool
variants, 2020-07-29), we introduced a `list_tool_variants` function
in the spirit of Postel's Law: be lenient in what you accept as input.
In this particular instance, we wanted to allow not only `bc` but also
`bc3` as name for the Beyond Compare tool.

However, what this patch overlooked is that it is totally allowed for
users to override the defaults in `mergetools/`. But now that we strip
off trailing digits, the name that the user gave the tool might not
actually be in the list produced by `list_tool_variants`.

So let's do the same as for the `diff_cmd` and the `merge_cmd`: override
it with the trivial version in case a user-defined setup was detected.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Nov 11, 2020
1 parent 0e2b11a commit c157c07
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions git-mergetool--lib.sh
Expand Up @@ -138,6 +138,10 @@ setup_user_tool () {
merge_cmd () {
( eval $merge_tool_cmd )
}

list_tool_variants () {
echo "$tool"
}
}

setup_tool () {
Expand Down

0 comments on commit c157c07

Please sign in to comment.