New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t3501: remove redundant test -f and use of git rev-parse #1195
Conversation
Welcome to GitGitGadgetHi @Labnann, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests. Please make sure that your Pull Request has a good description, as it will be used as cover letter. You can CC potential reviewers by adding a footer to the PR description with the following syntax:
Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:
It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code. Contributing the patchesBefore you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form Both the person who commented An alternative is the channel
Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment If you want to see what email(s) would be sent for a After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail). If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the curl -g --user "<EMailAddress>:<Password>" \
--url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):
To send a new iteration, just add another PR comment with the contents: Need help?New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join. You may also be able to find help in real time in the developer IRC channel, |
There are issues in commit a350151: |
a350151
to
8b7d38a
Compare
/allow |
User Labnann is now allowed to use GitGitGadget. WARNING: Labnann has no public email address set on GitHub; |
/preview |
Preview email sent as pull.1195.git.1648676204613.gitgitgadget@gmail.com |
/submit |
Submitted as pull.1195.git.1648676585765.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Ævar Arnfjörð Bjarmason wrote (reply to this):
|
User |
On the Git mailing list, Labnann wrote (reply to this):
|
On the Git mailing list, Labnann wrote (reply to this):
|
On the Git mailing list, Labnann wrote (reply to this):
|
On the Git mailing list, Labnann wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
36445b4
to
aeb28e3
Compare
On the Git mailing list, Labnann wrote (reply to this):
|
On the Git mailing list, Labnann wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
In the test 'cherry-pick after renaming branch', stop checking for the presence of a file (opos) because we are going to "grep" in it in the same test and the lack of it will be noticed as a failure anyway. In the test 'revert after renaming branch', instead of allowing any random contents as long as a known phrase is not there in it, we can expect the exact outcome---after the successful revert of "added", the contents of file "spoo" should become identical to what was in file "oops" in the "initial" commit. This test also contains 'test -f' that verifies presence of a file, but we have a helper function to do the same thing. Replace it with appropriate helper function 'test_path_is_file' for better readability and better error messages. In both tests, we will not notice when "git rev-parse" starts segfaulting without emitting any output. The 'test' command will end up being just "test =", which yields success. Use the 'test_cmp_rev' helper to make sure we will notice such a breakage. Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
aeb28e3
to
1090429
Compare
The public inbox and gitgitgadget here is not showing the recently sent emails at the mailing list. Is there a way to fix this? |
Are you saying that you sent mails manually and expected them to show up in https://lore.kernel.org/git/xmqqfsmssv1z.fsf@gitster.g/#r? The most common cause for mails not to make it there is that the Git mailing list simply drops mails that contain HTML, even if it is just an optional HTML part that is an alternative to the plaintext part. You will have to figure out a way to send plaintext-only mails |
On the Git mailing list, Khalid Masum wrote (reply to this):
|
On the Git mailing list, Khalid Masum wrote (reply to this):
|
On the Git mailing list, Khalid Masum wrote (reply to this):
|
This patch series was integrated into seen via git@e78637a. |
There was a status update in the "Cooking" section about the branch Test script updates. Will merge to 'next'. source: <20220405134742.17526-2-khalid.masum.92@gmail.com> |
This patch series was integrated into seen via git@f302f83. |
This patch series was integrated into seen via git@76d552f. |
There was a status update in the "Cooking" section about the branch Test script updates. Will merge to 'next'. source: <20220405134742.17526-2-khalid.masum.92@gmail.com> |
This patch series was integrated into seen via git@e98a165. |
This patch series was integrated into seen via git@4b7e6cb. |
There was a status update in the "Cooking" section about the branch Test script updates. Will merge to 'next'. source: <20220405134742.17526-2-khalid.masum.92@gmail.com> |
This patch series was integrated into seen via git@d6f5f44. |
This patch series was integrated into seen via git@db7fb7b. |
There was a status update in the "Cooking" section about the branch Test script updates. Will merge to 'next'. source: <20220405134742.17526-2-khalid.masum.92@gmail.com> |
This patch series was integrated into seen via git@8ef82c9. |
This patch series was integrated into seen via git@8647b44. |
This patch series was integrated into seen via git@64ae650. |
This patch series was integrated into next via git@66c5cd1. |
There was a status update in the "Cooking" section about the branch Test script updates. Will merge to 'master'. source: <20220405134742.17526-2-khalid.masum.92@gmail.com> |
This patch series was integrated into seen via git@cbb0670. |
This patch series was integrated into seen via git@883ff08. |
There was a status update in the "Cooking" section about the branch Test script updates. Will merge to 'master'. source: <20220405134742.17526-2-khalid.masum.92@gmail.com> |
This patch series was integrated into seen via git@90de6bf. |
This patch series was integrated into seen via git@d2ab973. |
This patch series was integrated into seen via git@86be34d. |
This patch series was integrated into seen via git@02ad2c3. |
This patch series was integrated into seen via git@6b3d47a. |
This patch series was integrated into master via git@6b3d47a. |
This patch series was integrated into next via git@6b3d47a. |
Closed via 6b3d47a. |
Two test -f are present in t3501. They can be replaced with appropriate helper function: test_path_is_file. Which makes the script more readable and gives better error messages.
Signed-off-by: Khalid Masumkhalid.masum.92@gmail.com
CC: Junio C Hamano gitster@pobox.com