commit-graph: emit trace2 cmd_mode for each sub-command

[garimasi514]

Emit trace2_cmd_mode() messages for each commit-graph
sub-command.

The commit graph commands were in flux when trace2 was
making it's way to git. Now that we have enough sub-commands
in commit-graph, we can label the various modes within them.
Distinguishing between read, write and verify is a great
start.

Signed-off-by: Garima Singh garima.singh@microsoft.com

CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com, avarab@gmail.com

[garimasi514]

/submit

[gitgitgadget]

Submitted as pull.323.git.gitgitgadget@gmail.com

[gitgitgadget]

On the Git mailing list, Garima Singh wrote (reply to this):

Ping :) Any thoughts on this?

On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:
> Emit trace2_cmd_mode() messages for each commit-graph sub-command.
> 
> The commit graph commands were in flux when trace2 was making it's way to
> git. Now that we have enough sub-commands in commit-graph, we can label the
> various modes within them. Distinguishing between read, write and verify is
> a great start.
> 
> Signed-off-by: Garima Singh garima.singh@microsoft.com
> [garima.singh@microsoft.com]
> 
> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,
> avarab@gmail.com
> 
> Garima Singh (1):
>    commit-graph: emit trace2 cmd_mode for each sub-command
> 
>   builtin/commit-graph.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> 
> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-323/garimasi514/coreGit-commit-graph-trace2-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/323
> 

[gitgitgadget]

On the Git mailing list, Jeff Hostetler wrote (reply to this):

On 9/10/2019 9:54 AM, Garima Singh wrote:
> Ping :) Any thoughts on this?
> 
> On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:
>> Emit trace2_cmd_mode() messages for each commit-graph sub-command.
>>
>> The commit graph commands were in flux when trace2 was making it's way to
>> git. Now that we have enough sub-commands in commit-graph, we can 
>> label the
>> various modes within them. Distinguishing between read, write and 
>> verify is
>> a great start.
>>
>> Signed-off-by: Garima Singh garima.singh@microsoft.com
>> [garima.singh@microsoft.com]
>>
>> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,
>> avarab@gmail.com
>>
>> Garima Singh (1):
>>    commit-graph: emit trace2 cmd_mode for each sub-command
>>
>>   builtin/commit-graph.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>>
>> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
>> Published-As: 
>> https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1 
>>
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git 
>> pr-323/garimasi514/coreGit-commit-graph-trace2-v1
>> Pull-Request: https://github.com/gitgitgadget/git/pull/323
>>

Looks good to me.  Thanks!

Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>

[gitgitgadget]

On the Git mailing list, Johannes Schindelin wrote (reply to this):

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-727874285-1570003388=:46
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 11 Sep 2019, Jeff Hostetler wrote:

> On 9/10/2019 9:54 AM, Garima Singh wrote:
> > Ping :) Any thoughts on this?
> >
> > On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:
> > > Emit trace2_cmd_mode() messages for each commit-graph sub-command.
> > >
> > > The commit graph commands were in flux when trace2 was making it's w=
ay to
> > > git. Now that we have enough sub-commands in commit-graph, we can la=
bel
> > > the
> > > various modes within them. Distinguishing between read, write and ve=
rify
> > > is
> > > a great start.
> > >
> > > Signed-off-by: Garima Singh garima.singh@microsoft.com
> > > [garima.singh@microsoft.com]
> > >
> > > CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,
> > > avarab@gmail.com
> > >
> > > Garima Singh (1):
> > > =C2=A0=C2=A0 commit-graph: emit trace2 cmd_mode for each sub-command
> > >
> > > =C2=A0 builtin/commit-graph.c | 6 ++++++
> > > =C2=A0 1 file changed, 6 insertions(+)
> > >
> > >
> > > base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
> > > Published-As:
> > > https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi51=
4%2FcoreGit-commit-graph-trace2-v1
> > >
> > > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git
> > > pr-323/garimasi514/coreGit-commit-graph-trace2-v1
> > > Pull-Request: https://github.com/gitgitgadget/git/pull/323
> > >
>
> Looks good to me.  Thanks!

This was not yet picked up into `pu`, correct? Or did I miss anything?

Ciao,
Dscho

>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>
>

--8323328-727874285-1570003388=:46--

[gitgitgadget]

This branch is now known as gs/commit-graph-trace-with-cmd.

[gitgitgadget]

This patch series was integrated into pu via git@d75ff90.

[gitgitgadget]

This patch series was integrated into pu via git@1f268d8.

[gitgitgadget]

This patch series was integrated into pu via git@7784210.

[gitgitgadget]

This patch series was integrated into pu via git@84302aa.

[gitgitgadget]

This patch series was integrated into pu via git@319d655.

[gitgitgadget]

This patch series was integrated into next via git@369df0e.

[gitgitgadget]

This patch series was integrated into pu via git@d7b11d7.

[gitgitgadget]

This patch series was integrated into pu via git@d37f22b.

[gitgitgadget]

This patch series was integrated into pu via git@f54949e.

[gitgitgadget]

This patch series was integrated into pu via git@73c10c3.

[gitgitgadget]

This patch series was integrated into pu via git@ccc2899.

[gitgitgadget]

This patch series was integrated into next via git@ccc2899.

[gitgitgadget]

This patch series was integrated into master via git@ccc2899.

[gitgitgadget]

Closed via ccc2899.