Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t: add tests for error conditions with --pathspec-from-file #502

Closed
wants to merge 1 commit into from
Closed

t: add tests for error conditions with --pathspec-from-file #502

wants to merge 1 commit into from

Conversation

SyntevoAlex
Copy link

@SyntevoAlex SyntevoAlex commented Dec 30, 2019 •
edited 

This patch adds tests for various cases where using `--pathspec-from-file` would result in a git error, such as using incompatible options.

This branch is a follow-up for [1] where part of branch was merged into `master` via [2].
The idea for these tests is from [3] where another error condition was added together with a test.

[1] https://lore.kernel.org/git/pull.490.git.1576161385.gitgitgadget@gmail.com/
[2] https://public-inbox.org/git/pull.445.v4.git.1575381738.gitgitgadget@gmail.com/
[3] https://public-inbox.org/git/4401823b-8039-99b4-2436-ed2f1a571d78@gmail.com/

Cc: Phillip Wood <phillip.wood@dunelm.org.uk>

@SyntevoAlex
t: add tests for error conditions with --pathspec-from-file
7a30d7e 
Also move some old tests into the new tests: it doesn't seem reasonable
to have individual error condition tests.

Old test for `git commit` was corrected, previously it was instructed
to use stdin but wasn't provided with any stdin. While this works at
the moment, it's not exactly perfect.

Old tests for `git reset` were improved to test for a specific error
message.

Suggested-By: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
@SyntevoAlex
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 30, 2019

Submitted as pull.502.git.1577720318.gitgitgadget@gmail.com

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 2, 2020

This branch is now known as am/test-pathspec-f-f-error-cases.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 2, 2020

This patch series was integrated into pu via git@02014e6.

@gitgitgadget gitgitgadget bot added the pu label Jan 2, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Jan 3, 2020

This patch series was integrated into pu via git@34aa1c6.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 5, 2020

This patch series was integrated into pu via git@f707f81.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 5, 2020

This patch series was integrated into next via git@73ac7e7.

@gitgitgadget gitgitgadget bot added the next label Jan 5, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Jan 6, 2020

This patch series was integrated into pu via git@7d65b9f.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 7, 2020

This patch series was integrated into pu via git@e8328df.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 8, 2020

This patch series was integrated into pu via git@1d85f83.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 9, 2020

This patch series was integrated into pu via git@679ee07.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 9, 2020

This patch series was integrated into pu via git@07d2504.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 10, 2020

This patch series was integrated into pu via git@e2240cc.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 13, 2020

This patch series was integrated into pu via git@4eec1b3.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 13, 2020

This patch series was integrated into pu via git@4b3e416.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 15, 2020

This patch series was integrated into pu via git@5f99621.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 17, 2020

This patch series was integrated into pu via git@c695a54.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 24, 2020

This patch series was integrated into pu via git@ca94b17.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 24, 2020

This patch series was integrated into next via git@cc526bc.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 27, 2020

This patch series was integrated into pu via git@8b4839a.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 30, 2020

This patch series was integrated into pu via git@96aef8f.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 30, 2020

This patch series was integrated into next via git@96aef8f.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 30, 2020

This patch series was integrated into master via git@96aef8f.

@gitgitgadget gitgitgadget bot added the master label Jan 30, 2020
@gitgitgadget gitgitgadget bot closed this Jan 30, 2020
@gitgitgadget
Copy link

gitgitgadget bot commented Jan 30, 2020

Closed via 96aef8f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master next pu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SyntevoAlex