New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Homebrew changing the gettext package #616
Conversation
/submit |
Submitted as pull.616.git.1587628367528.gitgitgadget@gmail.com |
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
On the Git mailing list, Eric Sunshine wrote (reply to this):
|
This branch is now known as |
This patch series was integrated into pu via git@5bee21c. |
On the Git mailing list, Carlo Marcelo Arenas Belón wrote (reply to this):
|
On the Git mailing list, Johannes Schindelin wrote (reply to this):
|
c56a232
to
0705da2
Compare
Apparently a recent Homebrew update now installs `gettext` into a subdirectory under /usr/local/, requiring the CFLAGS/LDFLAGS to list explicit directories _even_ when asking to force-link the `gettext` package. Likewise, the `msgfmt` tool is no longer in the `PATH`. While it is unclear which change is responsible for this breakage (that most notably only occurs on CI build agents that updated very recently), Homebrew/homebrew-core#53489 should fix it. Nevertheless, let's work around this issue, as there are still quite a few build agents out there that need some help in this regard: we explicitly do not call `brew update` in our CI/PR builds anymore. Helped-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
0705da2
to
1aa1b04
Compare
/submit |
Submitted as pull.616.v2.git.1587819266388.gitgitgadget@gmail.com |
On the Git mailing list, Johannes Schindelin wrote (reply to this):
|
On the Git mailing list, Carlo Arenas wrote (reply to this):
|
On the Git mailing list, Johannes Schindelin wrote (reply to this):
|
On the Git mailing list, Torsten Bögershausen wrote (reply to this):
|
On the Git mailing list, Carlo Marcelo Arenas Belón wrote (reply to this):
|
On the Git mailing list, tboegi@web.de wrote (reply to this):
|
This patch series was integrated into pu via git@af78f83. |
This patch series was integrated into pu via git@e01b23a. |
This patch series was integrated into pu via git@7e63811. |
This patch series was integrated into next via git@70c6eca. |
This patch series was integrated into pu via git@4b3afcb. |
This patch series was integrated into pu via git@aabf3ea. |
This patch series was integrated into next via git@aabf3ea. |
This patch series was integrated into master via git@aabf3ea. |
Closed via aabf3ea. |
In an early Azure Pipelines preview of what is to come, I saw the
osx-clang
andosx-gcc
jobs fail consistently.This patch tries to prevent that from affecting our CI/PR builds.
Changes since v1:
brew update
, some build agents, that won't matter for slightly out of date agents).Cc: SZEDER Gábor szeder.dev@gmail.com, Eric Sunshine sunshine@sunshineco.com, Carlo Marcelo Arenas Belón carenas@gmail.com