-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clone: add remote.cloneDefault config option #710
clone: add remote.cloneDefault config option #710
Conversation
Welcome to GitGitGadgetHi @sjbarag, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests. Please make sure that your Pull Request has a good description, as it will be used as cover letter. Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:
It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code. Contributing the patchesBefore you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form Both the person who commented An alternative is the channel
Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment If you want to see what email(s) would be sent for a After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail). If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the curl -g --user "<EMailAddress>:<Password>" \
--url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):
To send a new iteration, just add another PR comment with the contents: Need help?New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join. You may also be able to find help in real time in the developer IRC channel, |
There are issues in commit 6fb2369: |
6fb2369
to
1581587
Compare
There is an issue in commit 1581587: |
/allow |
User sjbarag is now allowed to use GitGitGadget. WARNING: sjbarag has no public email address set on GitHub |
Whoops! Email is now public. Thanks @dscho! |
While the default remote name of `origin` can be overridden both pre-clone (with `git clone --origin foo`) and post-clone (with `git remote rename origin foo`), it'd be handy to have a configurable system-wide default for clones! This commit implements `remote.cloneDefault` as a parallel to `remote.pushDefault`, with prioritized name resolution: 1. (Highest priority) `git clone`'s `-o` option 2. `git config`'s `remote.cloneDefault` value 3. `origin` There should be no impact for existing users, as it's pretty unlikely that anyone's already configured `remote.cloneDefault` and the porcelain hasn't changed (as best I can tell at least!). Signed-off-by: Sean Barag <sean@barag.org>
1581587
to
9cb1898
Compare
Time for a |
/preview |
Preview email sent as pull.710.git.1598456141200.gitgitgadget@gmail.com |
Preview looked sane, so I'm going to Thanks for all your help @dscho! You've made this very easy for a newcomer. |
/submit |
Submitted as pull.710.git.1598456751674.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
I'm glad! |
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Derrick Stolee wrote (reply to this):
|
User |
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Sean Barag wrote (reply to this):
|
User |
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Sean Barag wrote (reply to this):
|
Taking a different approach — will submit separate patch(es) later! |
While the default remote name of
origin
can be overridden bothpre-clone (with
git clone --origin foo
) and post-clone (withgit remote rename origin foo
), it'd be handy to have a configurablesystem-wide default for clones! This implements
remote.cloneDefault
as a parallel toremote.pushDefault
,with prioritized name resolution:
git clone
's-o
optiongit config
'sremote.cloneDefault
valueorigin
There should be no impact for existing users, as it's pretty unlikely
that anyone's already configured
remote.cloneDefault
and the porcelainhasn't changed (as best I can tell at least!).
cc: Derrick Stolee stolee@gmail.com
cc: Sean Barag sean@barag.org