pr-843/newren/ort-perf-batch-7-v2
tagged this
09 Feb 11:32
This series depends on ort-perf-batch-6[1]. This series uses file basenames in a basic fashion to guide rename detection. Changes since v1: * Significant edits to the commit messages to make them explain the basic idea better and (hopefully) prevent misunderstandings. * Add a commit at the end that updates the documentation and includes a new testcase * Modify the code to make it clearer that it can already handle using a different score for basename comparison similarity, even if we don't use that ability yet (see below) Changes not yet included -- I need input about what is wanted: * Stolee suggested not creating a separate score for basename comparisons, at least not yet. Junio suggested it may be prudent to use a higher score for that than whatever -M option the user provided for normal comparisons...but didn't suggest whether it should be a separate user-specified option, or some kind of weighted average of the -M option and MAX_SCORE (e.g. use 60% if -M is 50%, or use 80% if -M is 75%). I tweaked the code to make it clearer that it already is able to handle such a score difference, but I'm not sure what whether we want an automatically computed higher value or a user-controlled possibly higher value. [1] https://lore.kernel.org/git/xmqqlfc4byt6.fsf@gitster.c.googlers.com/ [2] https://github.com/newren/presentations/blob/pdfs/merge-performance/merge-performance-slides.pdf Elijah Newren (4): diffcore-rename: compute basenames of all source and dest candidates diffcore-rename: complete find_basename_matches() diffcore-rename: guide inexact rename detection based on basenames gitdiffcore doc: mention new preliminary step for rename detection Documentation/gitdiffcore.txt | 15 +++ diffcore-rename.c | 185 +++++++++++++++++++++++++++++++++- t/t4001-diff-rename.sh | 24 +++++ 3 files changed, 220 insertions(+), 4 deletions(-) base-commit: 7ae9460d3dba84122c2674b46e4339b9d42bdedd Submitted-As: https://lore.kernel.org/git/pull.843.v2.git.1612870326.gitgitgadget@gmail.com In-Reply-To: https://lore.kernel.org/git/pull.843.git.1612651937.gitgitgadget@gmail.com
Assets 2
-
2021-02-09T11:32:06Z -
2021-02-09T11:32:06Z - Loading