Fix the "double double quotes" problem in the "<author> via GitGitGadget" From: lines #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We correctly enclose "<author> via GitGitGadget" in double quotes, but if <author> already contained double quotes (e.g. because it contains dots), we failed to strip/escape them. This prevented gitgitgadget/git#435 from being sent correctly (it was sent all right, but the Git mailing list dropped the mails unceremoniously). Let's handle this correctly. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
webstech
reviewed
Nov 12, 2019
webstech
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully prevent problems like the one that prevented gitgitgadget/git#435 from arriving at the Git mailing list.