Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 바로가기 링크 에러 케이스 #496

Closed
ytaek opened this issue Sep 29, 2023 · 2 comments
Closed

PR 바로가기 링크 에러 케이스 #496

ytaek opened this issue Sep 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working ✨ view
Milestone

Comments

@ytaek
Copy link
Contributor

ytaek commented Sep 29, 2023

image

PR 링크 주위에 괄호가 있을 경우
https://github.com/githru/githru-vscode-ext/issues/#469)
로 연결됩니다.

@ytaek ytaek added bug Something isn't working ✨ view labels Sep 29, 2023
@ytaek ytaek added this to the v0.7.0 milestone Jun 8, 2024
@seungineer seungineer self-assigned this Jul 23, 2024
@seungineer
Copy link
Member

진행상황

  • Bug fix 하였으나 수정한 파일이 많아 검토 후 커밋 예정

참고

image
  • href에 URL이 올바르게 입력된 것을 알 수 있음
  • ${owner}/${repo}/issues/${number} 형식으로 URL이 지정되나 issuespull request이든 github에서 number에 맞게 redirection 함

@ytaek
Copy link
Contributor Author

ytaek commented Jul 30, 2024

진행상황

  • Bug fix 하였으나 수정한 파일이 많아 검토 후 커밋 예정

참고

image * `href`에 URL이 올바르게 입력된 것을 알 수 있음 * `${owner}/${repo}/issues/${number}` 형식으로 URL이 지정되나 `issues`든 `pull request`이든 github에서 `number`에 맞게 redirection 함

@seungineer 님, 일단 PR 올려주셔서 확인이 되면 더 좋을 것 같습니다.
수정한 파일이 부득이하게 많아졌을 경우라면, 중요 부분에다가 line by line comment들을 좀 달아주시면 리뷰 하시는 분들이 편할 때도 있습니다.

구조 변경(or refactoring)으로 인해 수정사항이 많아진 경우라면, 그 부분도 설명에 적어놔주시면 빠른 리뷰가 가능합니다!!

seungineer added a commit to seungineer/githru-vscode-ext that referenced this issue Jul 30, 2024
seungineer added a commit to seungineer/githru-vscode-ext that referenced this issue Jul 30, 2024
seungineer added a commit to seungineer/githru-vscode-ext that referenced this issue Jul 30, 2024
seungineer added a commit to seungineer/githru-vscode-ext that referenced this issue Jul 30, 2024
seungineer added a commit to seungineer/githru-vscode-ext that referenced this issue Jul 30, 2024
seungineer added a commit that referenced this issue Aug 2, 2024
fix(view): 커밋 메시지의 PR or Issue number 하이퍼링크 버그
@ytaek ytaek removed this from the v0.7.0 milestone Aug 19, 2024
@seungineer seungineer modified the milestones: v0.7.1, v0.7.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✨ view
Projects
None yet
Development

No branches or pull requests

2 participants