feat(view): ClusterGraph.const.ts의 DETAIL_HEIGHT 값 수정 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
수고하셨습니다! 디테일한 문제 잡아주셨네요!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
resolve #347
Result
Work list
Summary : DETAIL_HEIGHT을 245로 수정
Detail : clusterGraph.hook의 135번째 줄에서 drawClusterGraph가 DETAIL_HEIGHT을 인자로 받고 있는데 이 값이 ClusterGraph.const에서 220으로 지정되어 있었습니다.
그런데 summary의 detail_container에는 height 220px에 추가로 위, 아래 padding 값이 5px, 20px로 지정되어 있어 detail 오픈 시 높이가 어긋나는 현상이 있던 것으로 확인했습니다.
Discussion