feat(view): cluster node를 펼쳤을 때 avatar 보여주기 #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Aug 23, 2023
Comment on lines
+71
to
+79
| <div className="avatar-message"> | ||
| {authSrcMap && ( | ||
| <Author | ||
| name={author.names.toString()} | ||
| src={authSrcMap[author.names.toString()]} | ||
| /> | ||
| )} | ||
| <span className="message">{message}</span> | ||
| </div> |
There was a problem hiding this comment.
추후에,
map을 param으로 받는 방식도 괜찮지만,
authSrcMap[author.names.toString()]을 인자로 받거나, contextAPI등에서 데이터를 가져오는 방식도 고려해보면 좋을 것 같습니다.
KyuTae98
approved these changes
Aug 24, 2023
kimdonggu42
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit f0bc40e.
kimdonggu42
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit f0bc40e.
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
close #362
Result
Work list
기존 commit message 좌측에 author의 avatar를 추가했습니다.
Discussion
conflict를 해결하다가 이전 PR이 close 돼버려 다시 PR 올렸습니다.