Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(view): feat(view): cluster node를 펼쳤을 때 avatar 보여주기(build fail 수정) #408

Closed
wants to merge 7 commits into from

Conversation

kimdonggu42
Copy link
Member

Related issue

#404

Result

Aug-22-2023 11-21-09

Work list

  • 기존 commit message 좌측에 author의 avatar를 추가했습니다.
  • Detail.tsx의 아래 부분으로 인해 build fail이 발생하여 수정했습니다.
import { ReactComponent as AuthorIcon } from "assets/author.svg";
import { ReactComponent as ChangedFileIcon } from "assets/changed-file.svg";
import { ReactComponent as CommitIcon } from "assets/commit.svg";
import { ReactComponent as DiffAddIcon } from "assets/diff-add.svg";
import { ReactComponent as DiffDeleteIcon } from "assets/diff-delete.svg";
import { Author } from "components/@common/Author";

Discussion

build fail 수정하여 다시 PR 올렸습니다.

@kimdonggu42 kimdonggu42 requested review from a team as code owners August 24, 2023 04:46
Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KKanghh
Copy link
Contributor

KKanghh commented Aug 24, 2023

제 pr도 conflict 때문에 merge가 안되서 resolve 하면서 build fail 나는 부분 제가 수정하고 merge 했습니다!!

@kimdonggu42
Copy link
Member Author

제 pr도 conflict 때문에 merge가 안되서 resolve 하면서 build fail 나는 부분 제가 수정하고 merge 했습니다!!

앗 감사합니다ㅠㅠ 그럼 해당 PR은 close 하겠습니다!

@kimdonggu42 kimdonggu42 self-assigned this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants