feat(view): scss 모듈화 도입 #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2taesung
reviewed
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#445
Result
#445 에서 토의했던 SCSS 모듈을 도입했습니다.
타입스크립트에서 module.scss파일을 인식을 못해 src에 global.d.ts를 추가해 파일을 인식할 수 있게했습니다.
(모듈화 도입전)
(모듈화 도입후)
사진에서 보신것처럼 클래스 네임 뒤에 유니크한 해시값이 붙기 때문에
다른 파일에서 중복된 네이밍이 사용되더라도 문제가 되지 않습니다!
Work list
Discussion