Fixed issue #304 - entries of previous tags are included.

[thorsteneckel]

This pull requests fixes the issue #304 .

ATTENTION: This pull request changes the current behavior!

Current behavior:
Use since_tag or due_tag and every issue, PR etc. that happened before the last tag will get added to the last tag.

New behavior:
Use since_tag or due_tag and every issue, PR etc. that happened in the timeframe of the tags is added to the tags. Previous elements are not added to the list.

Feedback is welcome. Cheers!

[olleolleolle]

Damn this is nice to have done.

How can we make this testable?

I want to express the behavior using English and RSpec.

[thorsteneckel]

@olleolleolle I thought about adding tests and stuff but since there were none checking the current behavior I skipped them too. Imho there are some bigger changes on the structure necessary to test this properly. My suggestion would be to add a layer that makes it possible to mock github calls completely.

// edit:
This would come with the additional benefit of having a stable internal backend (Github client) API that makes it easier and safer to switch the gem from github_api to octokit or wherever.

[olleolleolle]

Does this change in behavior mean that options' descriptions need to change? Any other documentation around due_tag, since_tag?

[olleolleolle]

Update: I've now re-read the relevant issue that this fixes. It's great!

[thorsteneckel]

Wow! thanks @olleolleolle for merging this that fast.