Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "Racket" lexer for Racket. #313

Closed
wants to merge 3 commits into from
Closed

Use the "Racket" lexer for Racket. #313

wants to merge 3 commits into from

Conversation

greghendershott
Copy link

@greghendershott
Copy link
Author

Although Travis is failing with

/home/travis/builds/github/linguist/lib/linguist/language.rb:222:in `initialize': Racket is missing lexer (ArgumentError)

the 'Racket' lexer definitely does exist in latest pygments.rb. Is that something you need to update on your end, or am I doing something wrong?

@stevepiercy
Copy link
Contributor

FWIW, I am getting the exact same error for the Lasso lexer.
https://travis-ci.org/github/linguist/jobs/3546546/#L54
#235

Add `.rkt` to `extensions` as well as `primary_extension`.

From reviewing other languages, I believe this is unnecessary but
also harmless. In any case, I hope that pushing this will nudge
Travis to run again on my pull request, and pass. It should pass
because AFAICT linguist was updated to require the newer pygments.rb
containing the new Racket lexer, just _after_ my pull request.
@greghendershott
Copy link
Author

Well Travis failed it again. Why:

pygments/pygments.rb@330e820 has the new pygments-main containing the Racket lexer. But that happened soon after pygments.rb bumped its version to the current 0.3.2 (in pygments/pygments.rb@19e7334).

In other words it looks like the new pygments-main stuff will be in pygments.rb for sure by the time pygments.rb bumps its version to 0.3.3.

36e867e says

s.add_dependency 'pygments.rb',     '>= 0.3.0'

I don't speak Ruby well enough to know if that means it will use 0.3.3, but I hope so.

So if I understand correctly -- keep waiting, a bit longer?

@tnm
Copy link
Contributor

tnm commented Dec 17, 2012

@stevepiercy, @greghendershott — Correct. The 0.3.3 gem will have the new lexers.

Ulterior motive: Nudge Travis to run again.
Should succeed since pygments.rb gem updated to 0.3.4.
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants