Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imba programming language #3869

Closed
wants to merge 1 commit into from
Closed

Conversation

somebee
Copy link

@somebee somebee commented Oct 19, 2017

Read about imba at imba.io. It has 1.9k stars on GitHub. usage

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required, however they may be moot given my next note.

type: grammar
name: language-imba
license: mit
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to have been manually added rather than pulled in from the grammar repo itself.

The grammar repo needs to explicitly include a license file which script/add-grammar will automatically pull in and assess.

@@ -0,0 +1 @@
console.log "Hello, World!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this sample. We require only real-world usage samples and "hello world" is never real-world usage 😉

@lildude
Copy link
Member

lildude commented Mar 28, 2018

Sorry about the delay in getting to this PR. Unfortunately, it isn't popular enough on GitHub for this PR to be merged. At the moment, the stats are:

Total files found: 444
Unique public user/repos: 47
Unique owners: 23

As per the contributing guidelines at https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-an-extension-to-a-language "we prefer that extensions be in use in hundreds of repositories before supporting them in Linguist."

Accordingly, I'll added the "Pending popularity" label.

@pchaigno
Copy link
Contributor

pchaigno commented Aug 4, 2018

Closing in favor of #4219. We'll monitor the popularity of the extension there.

If you have an improved search query compared to the one used in #4219, please post it here and I'll update #4219.

@pchaigno pchaigno closed this Aug 4, 2018
@aalemayhu
Copy link

Hei,

what is the status on this? #4219 says there 58 repositories but this query shows more than 300
https://github.com/search?l=JavaScript&q=imba+fork%3Atrue&ref=advsearch&type=Repositories&utf8=✓

Thanks.

@pchaigno
Copy link
Contributor

pchaigno commented Oct 1, 2019

@scanf It looks like many of these repositories don't actually contain .imba files (look for repositories at the end of the search results). This is why we use the Code results in search queries instead. The search query I used in #4219 returns all .imba files on GitHub.

@aalemayhu
Copy link

@pchaigno ah, thanks for clarifying.

@manoger
Copy link

manoger commented Dec 18, 2020

Hello. is this language popular nowadays?

@Nixinova
Copy link
Contributor

Nixinova commented Aug 5, 2021

There's 1K results now, minus the imba/imba and imba/imba.io repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants