Use a tempfile instead of building our own. #4195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes cache writing to use the Tempfile class rather than
constructing our own tempfile. It means we don't have to deal with
unlinking the tempfile in case there's an exception, and it also fixes
this code on Ruby 2.5 (
Dir::Tmpname.make_tmpname
is no longeravailable)
Before this change:
After this change: