Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop cache tempfile in same dir #4199

Merged
merged 1 commit into from
Jul 18, 2018
Merged

drop cache tempfile in same dir #4199

merged 1 commit into from
Jul 18, 2018

Conversation

kivikakk
Copy link
Contributor

See #4195 (comment). We create the tempfile in the same directory as the cache file so when we do the rename it's not cross-device.

/cc @tenderlove @lildude

@kivikakk kivikakk mentioned this pull request Jul 18, 2018
Merged
@kivikakk
Copy link
Contributor Author

Confirmed this fixes the issue seen 👍

lildude
lildude approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kivikakk kivikakk merged commit eeb5dcf into master Jul 18, 2018
@kivikakk kivikakk deleted the tempfile-in-same-dir branch July 18, 2018 23:22
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kivikakk @lildude