Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect (third|3rd)Party with capital 'P' / 'T' as vendored #4356

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Detect (third|3rd)Party with capital 'P' / 'T' as vendored #4356

merged 1 commit into from
Jan 8, 2019

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Dec 17, 2018

I updated vendor.yml to detect 3rdParty and thirdParty with a capital P / T as being vendored.

Description

see above

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
      I did not, as the test/test_blob.rb#test_vendored method indicated at the top of the file only contained a single assertion for a README file.

lib/linguist/vendor.yml Outdated Show resolved Hide resolved
@TimWolla TimWolla changed the title Detect (third|3rd)Party with capital 'P' as vendored Detect (third|3rd)Party with capital 'P' / 'T' as vendored Dec 17, 2018
@pchaigno pchaigno requested a review from lildude January 3, 2019 14:17
@lildude lildude merged commit 29ac5ab into github-linguist:master Jan 8, 2019
@TimWolla TimWolla deleted the 3rdParty-vendored branch January 8, 2019 17:46
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants