Lazy load samples cache until Classifier is used #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samples.json is a very large (3.7M) json file, which allocates 183209 ruby strings, which takes 8.2MB of memory according to memsize_of. Instead of keeping the cache around when loading language.rb, we can instead just load the JSON and allow it to be GC'd after we use it. Cache will still be used if the Classifier is invoked.
jhawthorn
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
samples.json is a very large (3.7M) json file, which allocates 183209 ruby strings, which takes 8.2MB of memory according to memsize_of.
Instead of keeping the cache around when loading language.rb, we can instead just load the JSON and allow it to be GC'd after we use it. Cache will still be used if the Classifier is invoked.