-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kerboscript and Kickstart language #5981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other files on github use .ks for example "image kickstart files". Linguist classifies them as KerboScript but I do not know how to write heuristics rules to approach this. These "image kickstart files" are not in the database of linguist and the extension is not anywhere else in languages.yml so I ignored this for now.
We can't ignore this. There are way too many files that will be misclassified if we do. You're going to need to identify at least one other user of this extension that is popular enough and as it as part of this PR. If the languages are sufficiently different we can rely on samples and the classifier. If not we'll need heuristics which are just regexes.
There's no need to keep merging in master. It'll get done just before merging, which won't be happening until you've addressed the point I raised before. |
I've now added the Kickstart language myself. Unfortunately I didn't find an user who wanted to contribute to this PR. I have classified the type of kickstart as "data" in languages.yml because it is mainly used to "configure". For that reason I have not set the color.
I have included syntax highlighting grammar from @wgwoods https://github.com/wgwoods/language-kickstart Sorry for the mess with merging and pushing, I'm relatively new to git... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments. This looks good to go now 👍
Description
I have added the KerboScript language to the repository. It is the programming language of a mod of Kerbal Space Program called Kerbal Operating System. This mod is widely used under Kerbal Space Program players.
Some other files on github use
.ks
for example "image kickstart files". Linguist classifies them as KerboScript but I do not know how to write heuristics rules to approach this. These "image kickstart files" are not in the database of linguist and the extension is not anywhere else in languages.yml so I ignored this for now.Checklist: