Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .bicepparam to list of Bicep file extensions #6664

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

anthony-c-martin
Copy link
Contributor

@anthony-c-martin anthony-c-martin commented Jan 2, 2024

Add .bicepparam to list of Bicep file extensions

Description

We added the .bicepparam file extension to the Bicep language some time back, and have been keeping our textmate grammar updated with changes for it. It would be great to have GitHub highlighting enabled for it.

Checklist:

@anthony-c-martin anthony-c-martin requested a review from a team as a code owner January 2, 2024 18:33
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample is not a real world sample… "hello world" is never real code 😉

Please replace with a real world sample as requested in the CONTRIBUTING.md file.

@anthony-c-martin
Copy link
Contributor Author

This sample is not a real world sample… "hello world" is never real code 😉

Please replace with a real world sample as requested in the CONTRIBUTING.md file.

Done!

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit 3bbc4af Mar 8, 2024
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants