-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README-information is old. #12
Comments
The manual also mentions repo.list() - that doesn't seem to be in github.js? Showing a list of files in a repo would be v useful but I can't see this or any other function to create this list? :/ |
Fixed it. @mattpass did you test the Gists API? I'm just going to add documentation for it and include it in the 0.7.0 release. |
No, haven't tried it with gists. Will try tomorrow if I get chance. |
Don't forget to remove including jQuery dependency from 'setup' section of README, tis no longer needed. |
@mattpass can you hop on the #_substance channel in freebase.. got some questions.. (refining the api a bit atm) |
Sorry, don't use that but you're welcome to tweet me @mattpass or email matt@mattpass.com |
I'll push my changes and you can review.. stripping down the gists api a bit. Btw.. github gists api is really nice... we should cover gists by prose somehow.. |
Sure OK, will test the whole gists API in the morning and let you know how it goes. |
i'm already doing some testing. not sure how far i get. ····························································· On Monday, July 23, 2012 at 3:22 PM, mattpass wrote:
|
I stripped down the API a bit... we just need gist.update() I think.. so we don't obscure the native JSON-API which is well designed already.. I tested the stuff already... and extended the docs. Please add what's missing and let me know if you have other questions. Thanks for helping out with the implementation :) |
Sounds good, but a couple of issues. In the manual it says use The bigger problem though is I don't think fork, delete or update work? See here I have setup a demo page: http://icecoder.net/github/ Press F12 to get a console up and select gist.read from the dropdown. You get a response back, but not for git.fork or gist.delete? |
thanks a lot! |
Have been testing this a little today. I can read, fork, update & delete gists with basic auth fine. With oAuth I can only read them and can't fork, update or delete? Weird. May have set up my oAuth incorrectly. Can someone else confirm actions that involve authentication (such as forking, updating etc) works OK with oAuth here? |
Make sure you have the OAuth context set correctly it needs to have "gist" (you may revoke the token and get a new one). I was running into that problem yesterday. |
facepalm totally ignored the scope setting so has no context, just public perms. will have another look tomorrow but all 4 functions were working fine with basic auth so should be fine. |
Just fixed a bunch of other problems... + improved error handling (latest commit) GitHub API is having issues with content type determination... setting this: xhr.setRequestHeader('Content-Type','application/json'); made it work. Now we store content with special characters again. Arrr... HTTP sucks |
I thought it was a bit strange the content type was 'application/x-www-form-urlencoded' your previous jQuery AJAX version but I went along with it as I didn't want to break anything for you. Makes more sense now it's 'application/json'. Also good idea on the improved error handling. |
I also setup a new oAuth token (with gist perms this time) and everything works as expected. Tested all 4 gist commands (read, fork, update & delete) under basic & oAuth, works great. :D |
add function for fetching an organization
Now,
var repo = github.getRepo(reponame);
this is, maybe
var repo = github.getRepo(username, reponame);
The text was updated successfully, but these errors were encountered: