Uncaught TypeError: undefined is not a function in github.js:32

[DineshGK]

While call write/read methods it show error like: Uncaught TypeError: undefined is not a function in github.js:32
i try like this bellow...
repo.read('master', 'README.md', function(err, data) {});
repo.write('master', ' Test/README.md ', 'This is my New comment', '1st commit', function(err) {});

[dctr]

Line 32 is

  var xhr = new XMLHttpRequest();

The new code regards node.js:

if (typeof exports !== 'undefined') {
  var XMLHttpRequest = require('xmlhttprequest').XMLHttpRequest;
  var _ = require('underscore');
}

If i comment this out, the error is gone. Strangely i get this:

console.log(typeof exports); // undefined

However there is nothing wrong with my XHR, it works fine in other apps!

[michael]

Just did a quick fix. Please check if it works now.

[dctr]

nope, does not work.

furthermore: is this bound to the global object here? if yes, it does not change anything. if no, the code should not work with node.js anymore.

[michael]

this is bound to the global, which is either window (in the browser) or global (in Node.js).

So this code:

if (typeof this.exports !== 'undefined') {
    var XMLHttpRequest = require('xmlhttprequest').XMLHttpRequest;
    var _ = require('underscore');
}

should only be executed for the Node.js environment.

[dctr]

as it shouldn't be executed for the browser, as window does not have exports. nevertheless it gets executed. i lack a good explanation too...

[michael]

Exactly. Strange, just included the file and it works fine.

[dctr]

OK, some debug info: Firefox 20.0.1 64-bit Linux

[AmGK]

Hi all,

This code work for me...

  if(window.ActiveXObject) {
      xhr = new ActiveXObject("Microsoft.XMLHTTP");
  }
  else if(window.XMLHttpRequest) {
      xhr = new window.XMLHttpRequest();
  }

[dctr]

This issue is about node.js compatibility, not IE compatibility...

[AmGK]

Ok...But one more problem i am facing Guys..
For getting the Github object i write the code like follows
var github = new Github({
token: "08efd4412af3bffba593c",
auth: "oauth"
});

In the above code i want pass the toke dynamically for every individual github login user..How can i do this..
means How do i get github login user token.

Any appreciated answer ...
Thanks

[ixtli]

Doesn't work on chrome 26.0.1410.65 either.

var XMLHttpRequest = at the top of github.js isn't getting hit until after var xhr = new XMLHttpRequest(); so that variable has yet to be defined.

for what it's worth im doing the following:

this.github = new Github({
    username: user,
    password: pass,
    auth: "basic"
});

this.github.getUser().repos(function (err, repos) {
    console.log(err); console.log(repos);
});

and getting this error immediately. i fixed it by simply changing line 32 to var xhr = new window.XMLHttpRequest(); which i know doesn't work for IE. but, well, i don't really care about supporting IE for my purposes 👍

[holsted]

I'm having the same issue.

Chrome 26.0.1410.65 and Mountain Lion v10.8.3

var github = new Github({
    token: "my_oauth_token",
    auth: "oauth"
});

var user = github.getUser();
var myRepos = user.repos(function(err, repos) {
    console.log(repos);
});

results in the same error, Uncaught TypeError: undefined is not a function.

[mattwkelly]

@FajitaNachos change line 32 from

xhr = new XMLHttpRequest();

to

xhr = new window.XMLHttpRequest();

[w35l3y]

☝️

Was it fixed already? 'Cause it is working for me just fine.

[ingalls]

I am not able to reproduce this error either. Please open a new issue if this error comes up again.