This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fix broken build after clean or fresh clone #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the conditional logic that would switch between BuildTasks.14/BuildTools.15 based on the target Visual Studio version in StartProgram. Only use the Microsoft.VSSDK.BuildTools.15.0 package.
Use Microsoft.VSSDK.BuildTools.15.0.26201 in all projects.
No longer used.
Should restore and fix errors in another PR.
jcansdale
changed the title
jcansdale
changed the title
We're now using <PackageReference> for these projects.
grokys
approved these changes
Sep 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes the build errors after
git clean -xdfor fresh clone. The main fix was moving fromMicrosoft.VSSDK.BuildTools.15.0.26201to15.8.3252.I've also removed the old
Microsoft.VisualStudio.Sdk.BuildTasks.14.0package and hack (see #1726) to import it when launching Visual Studio 2015. This fixes some warnings but wasn't the main problem.Microsoft.VSSDK.BuildTools.15.0.26201to15.8.3252BuildTasks.14.0whenStartProgramtargeting Visual Studio 2015Sdk.BuildTasks.14.0packagespackages.config files from` projectsHow to test
https://github.com/github/VisualStudioTo confirm broken build before the update from
Microsoft.VSSDK.BuildTools.15.0.26201to15.8.3252.git reset 9cbf07820 --hardgit clean -xdfExpect first build to fail, but later builds to pass.
Related