Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Enable assembly resolver to ensure that Start Page and other icons can be found #1220

Merged
merged 9 commits into from Sep 14, 2017
Merged

Enable assembly resolver to ensure that Start Page and other icons can be found #1220

merged 9 commits into from Sep 14, 2017

Commits on Sep 6, 2017

  1. Re-enable AssemblyResolverPackage 

    Make `AssemblyResolverPackage` auto-load in case `devenv.exe.config` failed to update when extension was installed.
    @jcansdale
    jcansdale committed Sep 6, 2017
    Copy the full SHA
    6ce7fee View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. Make assembly resolver follow rules from ProvideDependentAssembly att… 

    …ributes

This makes assembly resolving behave more like when `devenv.exe.config` has been updated with `dependentAssembly` elements.
    @jcansdale
    jcansdale committed Sep 7, 2017
    Copy the full SHA
    7b0cc1a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2017

  1. Write to log if assembly is resolved 

    This should only happen if installer has failed or running unsigned build.
    @jcansdale
    jcansdale committed Sep 8, 2017
    Copy the full SHA
    d542218 View commit details
    Browse the repository at this point in the history

  2. Avoid logging during assembly resolve event 

    Assembly resolving should be as quick and side effect free as possible.
It's best to avoid triggering assembly loads or writing to disk during assembly resolves.
This change delays writing to the log until the package is being disposed.
    @jcansdale
    jcansdale committed Sep 8, 2017
    Copy the full SHA
    ef22d3b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2017

  1. No need to load assembly resolver on GitSccProviderId 

    VS 15.3 appears to load this later than it used to and it can no longer be relied on.
Loading on UICONTEXT.NoSolution seems to be enough.
    @jcansdale
    jcansdale committed Sep 12, 2017
    Copy the full SHA
    48c3841 View commit details
    Browse the repository at this point in the history

  2. Add note about when GitHub.VisualStudio gets auto-loaded

    @jcansdale
    jcansdale committed Sep 12, 2017
    Copy the full SHA
    7674dbd View commit details
    Browse the repository at this point in the history

  3. Tidy up

    @jcansdale
    jcansdale committed Sep 12, 2017
    Copy the full SHA
    13b5534 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2017

  1. Mark tests as public

    @jcansdale
    jcansdale committed Sep 13, 2017
    Copy the full SHA
    48ee1fb View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2017

  1. Merge branch 'master' into fixes/1217-devenv-config-not-updated

    @jcansdale
    jcansdale committed Sep 14, 2017
    Copy the full SHA
    7d6e8de View commit details
    Browse the repository at this point in the history