Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Fix icon color switch on theme change #133

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Conversation

shana
Copy link
Contributor

@shana shana commented Oct 23, 2015

Fixes #110

@haacked
Copy link
Contributor

haacked commented Oct 24, 2015

This does fix #110 in that the dark theme looks good. But now the light theme is too light!

918

@shana
Copy link
Contributor Author

shana commented Oct 24, 2015

Darn it! It switched colors just fine for me when I tested it! Why the heck is it not refreshing?? grumble

@haacked
Copy link
Contributor

haacked commented Oct 24, 2015

It switched colors just fine. I even switched to dark and back to light. It was still that faded color. Weird.

@shana
Copy link
Contributor Author

shana commented Oct 24, 2015

What non-dark theme did you try? Light or Blue? I might only have tested with the Blue one.

@haacked
Copy link
Contributor

haacked commented Oct 24, 2015

I did "Light"

@shana
Copy link
Contributor Author

shana commented Oct 26, 2015

@haacked I can tell this is on the connect page (because of the text), and this PR doesn't touch the connect page at all (only the invitation area on the sync page and the navigation items on the home page).

I can't reproduce this problem though. What color scheme did you start visual studio with, before switching to the light scheme? Or did this happen when it started up?

@haacked
Copy link
Contributor

haacked commented Oct 26, 2015

I can tell this is on the connect page (because of the text), and this PR doesn't touch the connect page at all (only the invitation area on the sync page and the navigation items on the home page).

Doh! My bad.

I can't reproduce this problem though. What color scheme did you start visual studio with, before switching to the light scheme? Or did this happen when it started up?

And I can no longer repro it either. I tested everything and this change looks good!

haacked added a commit that referenced this pull request Oct 26, 2015
Fix icon color switch on theme change
@haacked haacked merged commit 24738ae into master Oct 26, 2015
@haacked haacked deleted the shana/110-theme-changes branch October 26, 2015 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants