This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Factor sync submodules into VS command #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the sync submodules action into a VS command called GitHub.SyncSubmodules.
grokys
reviewed
May 3, 2018
|
|
||
| if (!complete) | ||
| { | ||
| statusBarNotificationService.ShowMessage("Failed to sync submodules." + Environment.NewLine + writer); |
There was a problem hiding this comment.
Is it normal for VS commands to write directly to the status bar? Is there no concept of "output" for commands, which e.g. shows in the command pane?
There was a problem hiding this comment.
I think the status bar is what commands tend to use as their ambient UI. There isn't really any concept of a native UI or output for a command.
One possibility would be to pass in a progress object that the command could report back to. This could also sidestep the issue of returning results.
I wanted to start off with a simple refactoring and and avoid any extra implementation detail. We can revisit next time this command is touched (if we decide to surface it somewhere else).
grokys
previously approved these changes
May 3, 2018
grokys
approved these changes
May 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
GitHub.SyncSubmodulesReviewers
I've extended the command interface to include a method that returns results from the command. Is this a reasonable thing to do if results are sometimes required from a command? It can also be used standalone without returning any results.
https://github.com/github/VisualStudio/blob/36e680e5a0cd936cafbd27af658335727d28841c/src/GitHub.Exports/Commands/ISyncSubmodulesCommand.cs#L16
Related to #1638