Pull Requests w/ Statuses

src/GitHub.App/GitHub.App.csproj

@@ -267,6 +267,7 @@
     <Compile Include="ViewModels\GitHubPane\NotAGitRepositoryViewModel.cs" />
     <Compile Include="ViewModels\GitHubPane\PullRequestReviewAuthoringViewModel.cs" />
     <Compile Include="ViewModels\GitHubPane\PullRequestReviewCommentViewModel.cs" />
+    <Compile Include="ViewModels\GitHubPane\PullRequestCheckViewModel.cs" />
     <Compile Include="ViewModels\GitHubPane\PullRequestReviewSummaryViewModel.cs" />
     <Compile Include="ViewModels\GitHubPane\PullRequestReviewViewModel.cs" />
     <Compile Include="ViewModels\GitHubPane\PullRequestUserReviewsViewModel.cs" />

src/GitHub.App/Models/PullRequestModel.cs

@@ -3,7 +3,6 @@
 using GitHub.Primitives;
 using GitHub.VisualStudio.Helpers;
 using System.Diagnostics;
-using System.Collections.Generic;
 using GitHub.Extensions;
 
 namespace GitHub.Models
@@ -125,6 +124,17 @@ public PullRequestStateEnum State
             }
         }
 
+        PullRequestChecksEnum checks;
+        public PullRequestChecksEnum Checks
+        {
+            get { return checks; }
+            set
+            {
+                checks = value;
+                this.RaisePropertyChange();
+            }
+        }
+
         // TODO: Remove these property once maintainer workflow has been merged to master.
         public bool IsOpen => State == PullRequestStateEnum.Open;
         public bool Merged => State == PullRequestStateEnum.Merged;
@@ -183,4 +193,4 @@ internal string DebuggerDisplay
             }
         }
     }
-}
+}

src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs

@@ -95,6 +95,36 @@ public PullRequestDetailViewModelDesigner()
             };
 
             Files = new PullRequestFilesViewModelDesigner();
+
+            var defaultAvatar = "pack://application:,,,/GitHub.App;component/Images/default_user_avatar.png";
+
+            Checks = new[]
+            {
+                new PullRequestCheckViewModel(null)
+                {
+                    Title = "continuous-integration/appveyor/branch",
+                    Description = "AppVeyor build succeeded",
+                    Status = PullRequestCheckStatusEnum.Success,
+                    AvatarUrl = defaultAvatar,
+                    Avatar = AvatarProvider.CreateBitmapImage(defaultAvatar),
+                },
+                new PullRequestCheckViewModel(null)
+                {
+                    Title = "continuous-integration/appveyor/pr",
+                    Description = "AppVeyor building",
+                    Status = PullRequestCheckStatusEnum.Pending,
+                    AvatarUrl = defaultAvatar,
+                    Avatar = AvatarProvider.CreateBitmapImage(defaultAvatar),
+                },
+                new PullRequestCheckViewModel(null)
+                {
+                    Title = "continuous-integration/appveyor/other",
+                    Description = "AppVeyor build failed",
+                    Status = PullRequestCheckStatusEnum.Failure,
+                    AvatarUrl = defaultAvatar,
+                    Avatar = AvatarProvider.CreateBitmapImage(defaultAvatar),
+                },
+            };
         }
 
         public PullRequestDetailModel Model { get; }
@@ -123,6 +153,8 @@ public PullRequestDetailViewModelDesigner()
         public ReactiveCommand<object> OpenOnGitHub { get; }
         public ReactiveCommand<object> ShowReview { get; }
 
+        public IReadOnlyList<IPullRequestCheckViewModel> Checks { get; }
+
         public Task InitializeAsync(ILocalRepositoryModel localRepository, IConnection connection, string owner, string repo, int number) => Task.CompletedTask;
 
         public string GetLocalFilePath(IPullRequestFileNode file)

src/GitHub.App/SampleData/PullRequestListItemViewModelDesigner.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
+using GitHub.Models;
 using GitHub.ViewModels;
 using GitHub.ViewModels.GitHubPane;
 
@@ -16,5 +17,6 @@ public class PullRequestListItemViewModelDesigner : ViewModelBase, IPullRequestL
         public int Number { get; set; }
         public string Title { get; set; }
         public DateTimeOffset UpdatedAt { get; set; }
+        public PullRequestChecksEnum Checks { get; set; }
     }
 }

src/GitHub.App/Services/ModelService.cs

@@ -440,6 +440,7 @@ IPullRequestModel Create(PullRequestCacheItem prCacheItem)
                 CommitCount = prCacheItem.CommitCount,
                 CreatedAt = prCacheItem.CreatedAt,
                 Head = Create(prCacheItem.Head),
+                Checks = prCacheItem.Checks ?? PullRequestChecksEnum.None,
                 State = prCacheItem.State.HasValue ?
                     prCacheItem.State.Value :
                     prCacheItem.IsOpen.Value ? PullRequestStateEnum.Open : PullRequestStateEnum.Closed,
@@ -577,6 +578,7 @@ public PullRequestCacheItem(PullRequest pr)
 
             // Nullable for compatibility with old caches.
             public PullRequestStateEnum? State { get; set; }
+            public PullRequestChecksEnum? Checks { get; set; }
 
             // This fields exists only for compatibility with old caches. The State property should be used.
             public bool? IsOpen { get; set; }

src/GitHub.App/Services/PullRequestService.cs

@@ -93,6 +93,17 @@ public class PullRequestService : IPullRequestService
                         Items = page.Nodes.Select(pr => new ListItemAdapter
                         {
                             Id = pr.Id.Value,
+                            LastCommit = pr.Commits(null, null, 1, null).Nodes.Select(commit =>
+                                new LastCommitSummaryModel
+                                {
+                                    Statuses = commit.Commit.Status
+                                            .Select(context =>
+                                                context.Contexts.Select(statusContext => new StatusSummaryModel
+                                                {
+                                                    State = (StatusStateEnum)statusContext.State,
+                                                }).ToList()
+                                            ).SingleOrDefault()
+                                }).ToList().FirstOrDefault(),
                             Author = new ActorModel
                             {
                                 Login = pr.Author.Login,
@@ -123,10 +134,46 @@ public class PullRequestService : IPullRequestService
 
             var result = await graphql.Run(readPullRequests, vars);
 
-            foreach (ListItemAdapter item in result.Items)
+            foreach (var item in result.Items.Cast<ListItemAdapter>())
             {
                 item.CommentCount += item.Reviews.Sum(x => x.Count);
                 item.Reviews = null;
+
+                var hasStatuses = item.LastCommit.Statuses != null 
+                                  && item.LastCommit.Statuses.Any();
+
+                if (!hasStatuses)
+                {
+                    item.Checks = PullRequestChecksEnum.None;
+                }
+                else
+                {
+                    var statusHasFailure = item.LastCommit
+                        .Statuses
+                        .Any(status => status.State == StatusStateEnum.Failure);
+
+                    var statusHasCompleteSuccess = true;
+                    if (!statusHasFailure)
+                    {
+                        statusHasCompleteSuccess =
+                            item.LastCommit.Statuses.All(status => status.State == StatusStateEnum.Success);
+                    }
+
+                    if (statusHasFailure)
+                    {
+                        item.Checks = PullRequestChecksEnum.Failure;
+                    }
+                    else if (statusHasCompleteSuccess)
+                    {
+                        item.Checks = PullRequestChecksEnum.Success;
+                    }
+                    else
+                    {
+                        item.Checks = PullRequestChecksEnum.Pending;
+                    }
+                }
+
+                item.LastCommit = null;
             }
 
             return result;
@@ -840,6 +887,8 @@ static string BuildGHfVSConfigKeyValue(string owner, int number)
         class ListItemAdapter : PullRequestListItemModel
         {
             public IList<ReviewAdapter> Reviews { get; set; }
+
+            public LastCommitSummaryModel LastCommit { get; set; }
         }
 
         class ReviewAdapter
@@ -848,5 +897,15 @@ class ReviewAdapter
             public int CommentCount { get; set; }
             public int Count => CommentCount + (!string.IsNullOrWhiteSpace(Body) ? 1 : 0);
         }
+
+        class LastCommitSummaryModel
+        {
+            public List<StatusSummaryModel> Statuses { get; set; }
+        }
+    }
+
+    public class StatusSummaryModel
+    {
+        public StatusStateEnum State { get; set; }
     }
 }

src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs

@@ -0,0 +1,119 @@
+using System;
+using System.Collections.Generic;
+using System.ComponentModel.Composition;
+using System.Linq;
+using System.Reactive;
+using System.Reactive.Linq;
+using System.Windows.Media.Imaging;
+using GitHub.Extensions;
+using GitHub.Factories;
+using GitHub.Models;
+using GitHub.Services;
+using ReactiveUI;
+
+namespace GitHub.ViewModels.GitHubPane
+{
+    [Export(typeof(IPullRequestCheckViewModel))]
+    [PartCreationPolicy(CreationPolicy.NonShared)]
+    public class PullRequestCheckViewModel: ViewModelBase, IPullRequestCheckViewModel
+    {
+        private readonly IUsageTracker usageTracker;
+        const string DefaultAvatar = "pack://application:,,,/GitHub.App;component/Images/default_user_avatar.png";
+
+        private string title;
+        private string description;
+        private PullRequestCheckStatusEnum status;
+        private Uri detailsUrl;
+        private string avatarUrl;
+        private BitmapImage avatar;
+
+        public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactory viewViewModelFactory, PullRequestDetailModel pullRequest)
+        {
+            return pullRequest.Statuses?.Select(model =>
+            {
+                var statusStateEnum = model.State;
+
+                PullRequestCheckStatusEnum checkStatus;
+                switch (statusStateEnum)
+                {
+                    case StatusStateEnum.Expected:
+                    case StatusStateEnum.Error:
+                    case StatusStateEnum.Failure:
+                        checkStatus = PullRequestCheckStatusEnum.Failure;
+                        break;
+                    case StatusStateEnum.Pending:
+                        checkStatus = PullRequestCheckStatusEnum.Pending;
+                        break;
+                    case StatusStateEnum.Success:
+                        checkStatus = PullRequestCheckStatusEnum.Success;
+                        break;
+                    default:
+                        throw new InvalidOperationException("Unkown PullRequestCheckStatusEnum");
+                }
+
+                var pullRequestCheckViewModel = viewViewModelFactory.CreateViewModel<IPullRequestCheckViewModel>();
+                pullRequestCheckViewModel.Title = model.Context;
+                pullRequestCheckViewModel.Description = model.Description;
+                pullRequestCheckViewModel.Status = checkStatus;
+                pullRequestCheckViewModel.DetailsUrl = new Uri(model.TargetUrl);
+                pullRequestCheckViewModel.AvatarUrl = model.AvatarUrl ?? DefaultAvatar;
+                pullRequestCheckViewModel.Avatar = model.AvatarUrl != null
+                    ? new BitmapImage(new Uri(model.AvatarUrl))
+                    : AvatarProvider.CreateBitmapImage(DefaultAvatar);
+
+                return pullRequestCheckViewModel;
+
+            }) ?? new PullRequestCheckViewModel[0];
+        }
+
+        [ImportingConstructor]
+        public PullRequestCheckViewModel(IUsageTracker usageTracker)
+        {
+            this.usageTracker = usageTracker;
+            OpenDetailsUrl = ReactiveCommand.Create().OnExecuteCompleted(DoOpenDetailsUrl);
+        }
+
+        private void DoOpenDetailsUrl(object obj)
+        {
+            usageTracker.IncrementCounter(x => x.NumberOfPRCheckStatusesOpenInGitHub).Forget();
+        }
+
+        public string Title
+        {
+            get { return title; }
+            set { this.RaiseAndSetIfChanged(ref title, value); }
+        }
+
+        public string Description
+        {
+            get { return description; }
+            set { this.RaiseAndSetIfChanged(ref description, value); }
+        }
+
+        public PullRequestCheckStatusEnum Status
+        {
+            get { return status; }
+            set { this.RaiseAndSetIfChanged(ref status, value); }
+        }
+
+        public Uri DetailsUrl
+        {
+            get { return detailsUrl; }
+            set { this.RaiseAndSetIfChanged(ref detailsUrl, value); }
+        }
+
+        public string AvatarUrl
+        {
+            get { return avatarUrl; }
+            set { this.RaiseAndSetIfChanged(ref avatarUrl, value); }
+        }
+
+        public BitmapImage Avatar
+        {
+            get { return avatar; }
+            set { this.RaiseAndSetIfChanged(ref avatar, value); }
+        }
+
+        public ReactiveCommand<object> OpenDetailsUrl { get; }
+    }
+}

src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs

@@ -55,6 +55,8 @@ public sealed class PullRequestDetailViewModel : PanePageViewModelBase, IPullReq
         bool refreshOnActivate;
         Uri webUrl;
         IDisposable sessionSubscription;
+        IViewViewModelFactory viewViewModelFactory;
+        IReadOnlyList<IPullRequestCheckViewModel> checks;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="PullRequestDetailViewModel"/> class.
@@ -73,21 +75,24 @@ public sealed class PullRequestDetailViewModel : PanePageViewModelBase, IPullReq
             IUsageTracker usageTracker,
             ITeamExplorerContext teamExplorerContext,
             IPullRequestFilesViewModel files,
-            ISyncSubmodulesCommand syncSubmodulesCommand)
+            ISyncSubmodulesCommand syncSubmodulesCommand,
+            IViewViewModelFactory viewViewModelFactory)
         {
             Guard.ArgumentNotNull(pullRequestsService, nameof(pullRequestsService));
             Guard.ArgumentNotNull(sessionManager, nameof(sessionManager));
             Guard.ArgumentNotNull(modelServiceFactory, nameof(modelServiceFactory));
             Guard.ArgumentNotNull(usageTracker, nameof(usageTracker));
             Guard.ArgumentNotNull(teamExplorerContext, nameof(teamExplorerContext));
             Guard.ArgumentNotNull(syncSubmodulesCommand, nameof(syncSubmodulesCommand));
+            Guard.ArgumentNotNull(viewViewModelFactory, nameof(viewViewModelFactory));
 
             this.pullRequestsService = pullRequestsService;
             this.sessionManager = sessionManager;
             this.modelServiceFactory = modelServiceFactory;
             this.usageTracker = usageTracker;
             this.teamExplorerContext = teamExplorerContext;
             this.syncSubmodulesCommand = syncSubmodulesCommand;
+            this.viewViewModelFactory = viewViewModelFactory;
             Files = files;
 
             Checkout = ReactiveCommand.CreateAsyncObservable(
@@ -302,6 +307,12 @@ public Uri WebUrl
         /// </summary>
         public ReactiveCommand<object> ShowReview { get; }
 
+        public IReadOnlyList<IPullRequestCheckViewModel> Checks
+        {
+            get { return checks; }
+            private set { this.RaiseAndSetIfChanged(ref checks, value); }
+        }
+
         /// <summary>
         /// Initializes the view model.
         /// </summary>
@@ -377,6 +388,8 @@ public async Task Load(PullRequestDetailModel pullRequest)
                 Body = !string.IsNullOrWhiteSpace(pullRequest.Body) ? pullRequest.Body : Resources.NoDescriptionProvidedMarkdown;
                 Reviews = PullRequestReviewSummaryViewModel.BuildByUser(Session.User, pullRequest).ToList();
 
+                Checks = PullRequestCheckViewModel.Build(viewViewModelFactory, pullRequest)?.ToList();
+
                 await Files.InitializeAsync(Session);
 
                 var localBranches = await pullRequestsService.GetLocalBranches(LocalRepository, pullRequest).ToList();