Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Style TreeViewItem #1842

Merged
merged 4 commits into from
Aug 10, 2018
Merged

Style TreeViewItem #1842

merged 4 commits into from
Aug 10, 2018

Conversation

grokys
Copy link
Contributor

@grokys grokys commented Aug 8, 2018

This PR adds a new style for TreeViewItem to match VS' theme.

Before:

image

After:

image

Fixes #1294

@grokys grokys added the WIP label Aug 8, 2018
@grokys grokys force-pushed the fixes/1294-style-treeviewitem branch from 387ff33 to 270d701 Compare August 8, 2018 12:03
@grokys grokys changed the title WIP: Style TreeViewItem Style TreeViewItem Aug 8, 2018
@jcansdale
Copy link
Collaborator

This is looking great. 😄

Being super pedantic, the vertical alignment of the icons isn't quite the same as Solution Explorer.

  • Solution Explorer
    image

  • Changes
    image

@grokys
Copy link
Contributor Author

grokys commented Aug 8, 2018

I think pedanticism is warranted here @jcansdale - that's pretty much what this PR is about ;) Will fix.

@grokys
Copy link
Contributor Author

grokys commented Aug 8, 2018

@jcansdale ok, adjusted that. It's still not identical to solution explorer (I can't work out how to get both the folder icons and the file icons to align identically - seems to be one or the other!) but it's pretty close.

@meaghanlewis
Copy link
Contributor

This LGTM ✔️

Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shiny. ❇️

@grokys grokys merged commit a119e89 into master Aug 10, 2018
@grokys grokys deleted the fixes/1294-style-treeviewitem branch August 10, 2018 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants