This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Display help/doc links info only when in a GitHub repo #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
approved these changes
May 4, 2017
grokys
suggested changes
May 4, 2017
Previously our view model base interface/class (`IView` and `BaseViewModel`) had a bunch of properties that weren't relevant to many view/view models. Refactored them into a more granular hierarchy.
They were dialog view models, but they should have been pane pages.
Refactor the `Done` and `Cancel` signals from `IDialogView` into `IHasDone` and `IHasCancel` interfaces so that views can define their capabilities in a more granular fashion. This has the slightly unfortunate side-effect of leaving `IDialogView` with only a single `IsBusy` signal which can't be refactored out into an interface because we already have an incompatible `IHasBusy` which is implemented by the view models. This will be resolved in the next step of refactoring where the signals are moved from the views to the view models.
When building outside of VS, use the NuGet package tooling. When building inside VS, use the installed VS SDK version.
I don't think we need to copy Vsix extension files to a directory in the `GitHub.StartPage` project and then link `GitHub.StartPage.pkgdef` from `GitHub.VisualStudio`. It looks like there's a build in way.
Moved the `Done` and `Cancel` observables out of the views and into the view models. In doing so, moved `IDialogViewModel` into `GitHub.Exports.Reactive` and removed `IReactiveDialogViewModel`.
The term "load" is rather um, overloaded, so try using something else.
Rather than `IsLoading`.
Add a local test SharedDictionary.xaml.
Everywhere now uses `GitHub.UI.ThemeDictionaryManager`. SharedDictionaryManager can be used as base for added functionality (e.g. ThemeDictionaryManager).
I introduced a compile error with the recent merge of 2.2.0.10 to master, because `SharedDictionaryManager` has moved. This fixes it.
Redirect to the latest `GitHub.*` assembly for assemblies that require a CodeBase (e.g. `GitHub.Exports`). This makes extensions that don't depend on a specific GHfVS version possible.
paladique
force-pushed
the
fixes/971-show-docs-when-github-repo
branch
from
8ebc32a
to
2146f22
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An info panel with links to docs and training displays in Team Explorer, but can be misleading when not in a GitHub repo. Only display the panel when the user is in a GitHub hosted repo.
Fixes #971