Output MySQL backup strategy for clarity during backup and restore

[cainejette]

Adds some verbosity around logical vs binary backups as configured on the appliance, as well as if the snapshot itself in the restore process is binary vs logical

Backup output with binary backups not set:

$ ./backup-utils/bin/ghe-backup 
Starting backup of 10.0.1.171 with backup-utils v2.21 in snapshot 20200514T035830
Connect 10.0.1.171:122 OK (v2.21.0)
Backing up GitHub settings ...
Backing up SSH authorized keys ...
Backing up SSH host keys ...
Backing up MySQL database using logical backup strategy ...

Backup output with binary backups set:

$ ./backup-utils/bin/ghe-backup 
Starting backup of 10.0.1.171 with backup-utils v2.21 in snapshot 20200514T035902
Connect 10.0.1.171:122 OK (v2.21.0)
Backing up GitHub settings ...
Backing up SSH authorized keys ...
Backing up SSH host keys ...
Backing up MySQL database using binary backup strategy ...

Restore output against logical appliance with logical backup:

$ ./bin/ghe-restore -s 20200514T045636 10.0.1.171
Checking for leaked keys in the backup snapshot that is being restored ...
* No leaked keys found
Connect 10.0.1.171:122 OK (v2.21.0)

WARNING: All data on GitHub Enterprise appliance 10.0.1.171 (v2.21.0)
         will be overwritten with data from snapshot 20200514T045636.
Please verify that this is the correct restore host before continuing.
Type 'yes' to continue: yes

Starting restore of 10.0.1.171:122 with backup-utils v2.21 from snapshot 20200514T045636
Stopping cron and github-timerd ...
Restoring UUID ...
Restoring MySQL database from logical backup snapshot on an appliance configured for logical backups ...

Restore output against binary appliance with logical backup:

$ ./bin/ghe-restore -s 20200514T045636 10.0.1.171
Checking for leaked keys in the backup snapshot that is being restored ...
* No leaked keys found
Connect 10.0.1.171:122 OK (v2.21.0)

WARNING: All data on GitHub Enterprise appliance 10.0.1.171 (v2.21.0)
         will be overwritten with data from snapshot 20200514T045636.
Please verify that this is the correct restore host before continuing.
Type 'yes' to continue: yes

Starting restore of 10.0.1.171:122 with backup-utils v2.21 from snapshot 20200514T045636
Stopping cron and github-timerd ...
Restoring UUID ...
Restoring MySQL database from logical backup snapshot on an appliance configured for binary backups ...

[ryansimmen]

Approved

[ipmsteven]

is that possible:
The Appliance is configured for binary backups, but Backup being restored is a logical backup?

[cainejette]

Looks like it: https://github.com/github/backup-utils/blob/echo-msyql-backup-strategy/share/github-backup-utils/ghe-restore-mysql#L78-L81