Leaked host key check: Avoid false positives from FIPS mode #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling FIPS (Federal Information Processing Standards) mode may cause ssh-keygen's MD5-based fingerprint generation to fail, resulting in a message on stderr and a blank fingerprint string. A grep search for an empty string succeeds so a blank fingerprint is reported as a leaked host key.
bwestover
approved these changes
Jun 22, 2021
KarlaKennedydian
referenced
this pull request
Jun 30, 2021
|
The macos CI failure here is a known failure, so I think this is good to merge @mumfy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling FIPS (Federal Information Processing Standards) mode on the backup server
may cause
ssh-keygen's MD5-based fingerprint generation to fail.A "fingerprint_one_key: sshkey_fingerprint failed" message is written to stderr
whilst nothing is written to stdout, so the
fingerprintvariable is blank.A grep search for an empty string succeeds, so
ghe-detect-leaked-ssh-keysreports that a leaked hostkey was found.
This change detects this condition and the final output says if the hostkey check was skipped.
closes: #749