Improve cross-platform compatibility #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sed implementations, like that on Solaris, don't process lines which don't end in EOL/newline. Forcing a newline helps these versions.
This makes the grep commands cross-platform compatible.
|
Looks good to me. Merging. |
rtomayko
added a commit
that referenced
this pull request
Dec 12, 2014
Improve cross-platform compatibility
rtomayko
added a commit
that referenced
this pull request
Jan 14, 2015
See #86. Think this was just stomped from an earlier version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing on Solaris 10, it was discovered there are quite a few incompatibilities caused by Solaris 10 not using GNU or POSIX-compliant commands by default.
These changes make things more compatible.
This fixes most of the things detailed in https://github.com/github/backup-utils/issues/85 - we just need to decide what we're going to do about the hashbang, if anything.