Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock bug #187

Merged
merged 12 commits into from
Aug 16, 2023
Merged

Lock bug #187

merged 12 commits into from
Aug 16, 2023

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Aug 16, 2023

Lock Bug

This pull request does the following:

  • Resolves a bug where .lock <env> --reason <text> commands are treated like a .wcid or .lock --info command when they shouldn't be. This only occurs when .lock commands had a lockInfoFlag inside of the command. Something like .lock --reason "doing a branch-deploy" would be treated as a .lock -d command because of the -d in -deploy 😵‍💫 . This has been resolved by adding a leading space character to the lockInfoFlags
  • Adds a lot more debug logging to the lock() methods

resolves: #186

@GrantBirki GrantBirki added bug Something isn't working enhancement New feature or request labels Aug 16, 2023
@GrantBirki GrantBirki self-assigned this Aug 16, 2023
@GrantBirki
Copy link
Member Author

Screenshot 2023-08-16 at 11 06 40 PM

Now it works!

@GrantBirki GrantBirki merged commit 13ae6c8 into main Aug 16, 2023
4 checks passed
@GrantBirki GrantBirki deleted the lock-bug branch August 16, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.lock and .unlock commands not working with --reason
1 participant