Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new github emu check #227

Merged
merged 2 commits into from
Dec 18, 2023
Merged

use new github emu check #227

merged 2 commits into from
Dec 18, 2023

Conversation

GrantBirki
Copy link
Member

Support GitHub EMU Handles

This pull request enables support for GitHub EMU handles.

This is accomplished by swapping out the very outdated npm package that handles GitHub username regex support. The new npm package is one that I have written that supports both traditional GitHub dotcom handles in addition to GitHub EMU handles.

related: github/command#15, github/command#10

@GrantBirki GrantBirki added the enhancement New feature or request label Dec 18, 2023
@GrantBirki GrantBirki self-assigned this Dec 18, 2023
Copy link
Member

@northrup northrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤘

@GrantBirki GrantBirki merged commit 9e2d366 into main Dec 18, 2023
4 checks passed
@GrantBirki GrantBirki deleted the handle-github-emu-usernames branch December 18, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants