Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add guide page about lifecycle hooks #62

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

keithamus
Copy link
Member

What?

This adds documentation around the lifecycle hooks that custom elements provide.

Why?

This offers some small use to developers, compared to MDN:

  • It's easier to find than MDN's pages on this.
  • It's more succinct, than an MDN article.
  • It is more pragmatic than the MDN article, e.g. saying "you'll almost never need [adoptedCallback]"

Largely though, it gives us a space to document our own developed lifecylce methods. Which we plan to do.

@keithamus keithamus requested a review from a team as a code owner July 28, 2020 16:57
@github-pages github-pages bot temporarily deployed to github-pages July 28, 2020 16:58 Inactive
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍🏻

@github-pages github-pages bot temporarily deployed to github-pages July 29, 2020 09:25 Inactive
@keithamus keithamus merged commit c07f507 into master Jul 29, 2020
@keithamus keithamus deleted the docs-add-lifecycle-methods branch July 29, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants