Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to listenForBind batch argument #66

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

joshmgross
Copy link
Member

listenForBind only takes a single argument, but the documentation mentions a second "batch size" argument.

export function listenForBind(el: Node = document): Subscription {

listenForBind only takes a single argument, so the docs should not mention a second argument.
@joshmgross joshmgross added the documentation Improvements or additions to documentation label Jul 30, 2020
@joshmgross joshmgross requested a review from a team as a code owner July 30, 2020 20:41
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @joshmgross!

I'm thinking it might be useful to remove listenForBind entirely from the docs; it's something Catalyst should manage internally, but we're not quite sure how yet. When we reach 1.0 we certainly won't document it.

@joshmgross joshmgross merged commit add9f8f into master Jul 31, 2020
@joshmgross joshmgross deleted the joshmgross/docs-listenForBind-batch branch July 31, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants