-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with pipes inside of backpacks inside a table #24
Comments
This issue has been discussed in the Commonmark Discourse as well. As a user, I almost always don't want vertical bars |
👋 @Crissov As a user, I didn't want that either — that's why I went to quite so much effort to make it work correctly. Like any developer, too, I wasn't really happy about throwing that away in #21 for this "solution", but unfortunately when confronted with situations like in #18, it turned out to be unsustainable; the edge cases get weirder and weirder, and trying to cover them up (#19) just makes for an even harder to explain system, the edge cases get even stranger, and the code starts to become a nightmare. (We ended up parsing inlines three times for each row there, iirc.) Simply put, there's not a great, consistent way to do this. I think it does make sense to consider the table cell structure at the block level, inasmuch as they're not spanned by delimiters but rather separated by them. It's easiest to consider the entire table structure one large block which in parsed in its entirety, before inline parsing then happens, which is also literally the case. |
As I said, I understand it from a developer's POV. |
Escape pipe characters with backslash since even inside backticks, GitHub flavored markdown treats it as a table delimiter, not a literal pipe. See github/cmark-gfm#24 for background. (Thanks to @flwyd for pointing this out!)
Actual Result:
This used to work as expected.
id
description
string
approval
resource, if available.Expected Result:
id
integer|null
approval
resource, if available.description
string
approval
resource, if available.The text was updated successfully, but these errors were encountered: