Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ATM pack v0.4.0 for CLI v2.11.3 and above #1351

Merged
merged 1 commit into from Nov 8, 2022

Conversation

kaeluka
Copy link
Contributor

@kaeluka kaeluka commented Nov 8, 2022

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@kaeluka
Copy link
Contributor Author

kaeluka commented Nov 8, 2022

I'm assuming that README and CHANGELOG don't need to be updated, since the last PR also didn't.

@kaeluka
Copy link
Contributor Author

kaeluka commented Nov 8, 2022

I'm also assuming that backwards-compatibility is given, but this is my first PR to this repo, so I'm asking the reviewer (@henrymercer?) to confirm that, please :)

@kaeluka kaeluka marked this pull request as ready for review November 8, 2022 12:41
@kaeluka kaeluka requested a review from a team as a code owner November 8, 2022 12:41
@kaeluka kaeluka merged commit 73ff862 into github:main Nov 8, 2022
308 checks passed
@adityasharad
Copy link
Contributor

Perhaps it is time to start updating the changelog (separate PR is fine), at least for our own convenience. Something similar to what we do when updating the CLI version will suffice: Update the ML-powered additional query pack for JavaScript to version x.y.z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants