Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the external repository token to the CLI #1464

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jan 6, 2023

This commit does a few related things:

  1. Bumps the minimum version for cli config parsing to 2.10.6
  2. Ensures that if cli config parsing is enabled, then remove repos
    are not downloaded by the action. It happens in the CLI.
  3. Passes the --external-repository-token-stdin option to the CLI
    and passes the appropriate token via stdin if cli config parsing is
    enabled.

See the linked, internal PR for the integration test associated with this change.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner January 6, 2023 01:35
@aeisenberg aeisenberg marked this pull request as draft January 6, 2023 01:35
@aeisenberg aeisenberg removed the request for review from a team January 6, 2023 01:35
@aeisenberg aeisenberg force-pushed the aeisenberg/externalRepoTokenConfigParsing branch 5 times, most recently from b62c79e to c17dc61 Compare January 6, 2023 22:33
This commit does a few related things:

1. Bumps the minimum version for cli config parsing to 2.10.6
2. Ensures that if cli config parsing is enabled, then remove repos
   are _not_ downloaded by the action. It happens in the CLI.
3. Passes the `--external-repository-token-stdin` option to the CLI
   and passes the appropriate token via stdin if cli config parsing is
   enabled.
@aeisenberg aeisenberg force-pushed the aeisenberg/externalRepoTokenConfigParsing branch from c17dc61 to 4023575 Compare January 6, 2023 22:46
@aeisenberg
Copy link
Contributor Author

aeisenberg commented Jan 7, 2023

Failing test is because the cached version of the cli is too old to be using cli config parsing now, so the cli config files are not generated. The test will start passing when the cached version becomes 2.11.6.

@aeisenberg aeisenberg marked this pull request as ready for review January 7, 2023 00:18
@aeisenberg aeisenberg requested review from a team and henrymercer January 7, 2023 00:18
@aeisenberg
Copy link
Contributor Author

@henrymercer, I think you are the one with the most background to review. Can you take a look?

henrymercer
henrymercer previously approved these changes Jan 10, 2023
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but this looks generally good to me 👍

src/codeql.ts Outdated Show resolved Hide resolved
src/codeql.ts Outdated Show resolved Hide resolved
src/codeql.ts Outdated Show resolved Hide resolved
@aeisenberg
Copy link
Contributor Author

Failures due to using a kotlin version that is too new. Updating the base branch should fix it.

@aeisenberg aeisenberg merged commit 42d6d35 into main Jan 10, 2023
@aeisenberg aeisenberg deleted the aeisenberg/externalRepoTokenConfigParsing branch January 10, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants