Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation notice to state that CodeQL Action v1 is discontinued #1481

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

henrymercer
Copy link
Contributor

For now, link the changelog post announcing the deprecation. However, we expect to publish a new changelog note confirming that the CodeQL Action v1 is now discontinued. Once that's out we should link it from the notice and changelog.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 16, 2023 18:43
aeisenberg
aeisenberg previously approved these changes Jan 16, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
nickfyson
nickfyson previously approved these changes Jan 18, 2023
Copy link
Contributor

@nickfyson nickfyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes since last approval

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/ Give me a 404. I'm guessing this is because it hasn't been released yet, but please make sure this is the right link.

@henrymercer
Copy link
Contributor Author

henrymercer commented Jan 18, 2023

That's right, this is my guess is to what the URL will be so we can hopefully avoid rerunning the checks and another approval cycle, but the changelog note isn't out yet.

@henrymercer
Copy link
Contributor Author

Changelog post now published.

@henrymercer henrymercer merged commit 597c204 into main Jan 18, 2023
@henrymercer henrymercer deleted the henrymercer/discontinue-v1 branch January 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants