Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of fatal CLI errors #1795

Merged
merged 13 commits into from
Jul 24, 2023
Merged

Conversation

henrymercer
Copy link
Contributor

Currently we are losing information about CLI errors in database {finalize,interpret-results,run-queries}. When the CLI command includes "A fatal error occurred" in its stderr, we lose other context about the error (such as whether it was an OOM, or out of disk, or something else) in the Actions run summary and in telemetry.

Furthermore, the Action is suppressing the improved errors for no code found shipped in CodeQL v2.12.4.

This PR stops suppressing these errors by displaying fatal errors in full, and using the CLI error message for database finalize no code found errors for CodeQL CLI v2.12.4 and later. Most of the commits are tweaking the error message to try to improve its utility. In particular, we're quite keen to get it on a single line if we can, as this lets us include all the useful detail we can on the Actions run summary page.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner July 21, 2023 14:17
@henrymercer henrymercer merged commit 57a11be into main Jul 24, 2023
342 checks passed
@henrymercer henrymercer deleted the henrymercer/use-more-cli-errors branch July 24, 2023 16:16
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants