Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the code_scanning_codeql_java_lombok feature flag #1809

Merged
merged 11 commits into from
Aug 2, 2023

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Jul 27, 2023

I think the minimumVersion could be older, but I don't think it's worth the time to work out exactly how old.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@igfoo igfoo requested a review from a team as a code owner July 27, 2023 11:24
@@ -58,6 +59,11 @@ export const featureConfig: Record<
Feature,
{ envVar: string; minimumVersion: string | undefined; defaultValue: boolean }
> = {
[Feature.CodeqlJavaLombokEnabled]: {
envVar: "CODEQL_JAVA_LOMBOK_ENABLED",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the others environment variable overrides for the feature flag!

Suggested change
envVar: "CODEQL_JAVA_LOMBOK_ENABLED",
envVar: "CODEQL_JAVA_LOMBOK",

angelapwen
angelapwen previously approved these changes Jul 27, 2023
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

angelapwen
angelapwen previously approved these changes Jul 27, 2023
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it 😸

angelapwen
angelapwen previously approved these changes Jul 27, 2023
src/init-action.ts Outdated Show resolved Hide resolved
henrymercer
henrymercer previously approved these changes Jul 28, 2023
@coadaflorin coadaflorin merged commit 2192e34 into main Aug 2, 2023
342 checks passed
@coadaflorin coadaflorin deleted the igfoo/code_scanning_codeql_java_lombok branch August 2, 2023 11:47
@github-actions github-actions bot mentioned this pull request Aug 8, 2023
6 tasks
@igfoo igfoo mentioned this pull request Jan 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants