Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the npm group with 6 updates #1949

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2023

Bumps the npm group with 6 updates:

Package From To
@actions/github 5.1.1 6.0.0
@types/js-yaml 4.0.6 4.0.7
@types/sinon 10.0.17 10.0.19
@typescript-eslint/eslint-plugin 6.7.5 6.8.0
@typescript-eslint/parser 6.7.5 6.8.0
nock 13.3.3 13.3.4

Updates @actions/github from 5.1.1 to 6.0.0

Changelog

Sourced from @​actions/github's changelog.

6.0.0

  • Support the latest Octokit in @​actions/github #1553
    • Drop support of NodeJS v14, v16
Commits

Updates @types/js-yaml from 4.0.6 to 4.0.7

Commits

Updates @types/sinon from 10.0.17 to 10.0.19

Commits

Updates @typescript-eslint/eslint-plugin from 6.7.5 to 6.8.0

Release notes

Sourced from @​typescript-eslint/eslint-plugin's releases.

v6.8.0

6.8.0 (2023-10-16)

Bug Fixes

  • eslint-plugin: [consistent-type-imports] import assertion checks added (#7722) (afdae37)
  • eslint-plugin: [no-shadow] fix static class generics for class expressions (#7724) (e5ea1d0)
  • eslint-plugin: [no-unsafe-member-access] report on only the accessed property (#7717) (f81a2da)
  • eslint-plugin: [no-useless-empty-export] exempt .d.ts (#7718) (ac397f1)

Features

  • eslint-plugin: add new extended rule prefer-destructuring (#7117) (3c6379b)

You can read about our versioning strategy and releases on our website.

Changelog

Sourced from @​typescript-eslint/eslint-plugin's changelog.

6.8.0 (2023-10-16)

Bug Fixes

  • eslint-plugin: [consistent-type-imports] import assertion checks added (#7722) (afdae37)
  • eslint-plugin: [no-shadow] fix static class generics for class expressions (#7724) (e5ea1d0)
  • eslint-plugin: [no-unsafe-member-access] report on only the accessed property (#7717) (f81a2da)
  • eslint-plugin: [no-useless-empty-export] exempt .d.ts (#7718) (ac397f1)

Features

  • eslint-plugin: add new extended rule prefer-destructuring (#7117) (3c6379b)

You can read about our versioning strategy and releases on our website.

Commits
  • d475f88 chore: publish v6.8.0
  • 3d58813 build: fix introduced post-merge build break with no-useless-empty-export
  • 3c6379b feat(eslint-plugin): add new extended rule prefer-destructuring (#7117)
  • afdae37 fix(eslint-plugin): [consistent-type-imports] import assertion checks added (...
  • e5ea1d0 fix(eslint-plugin): [no-shadow] fix static class generics for class expressio...
  • ac397f1 fix(eslint-plugin): [no-useless-empty-export] exempt .d.ts (#7718)
  • f81a2da fix(eslint-plugin): [no-unsafe-member-access] report on only the accessed pro...
  • cff6e47 docs(eslint-plugin): deduplicate examples for no-explicit-any (#7715)
  • afee34c chore: use named import for util (#7669)
  • a9c7928 docs(eslint-plugin): [explicit-function-return-type] fix typo in option name ...
  • See full diff in compare view

Updates @typescript-eslint/parser from 6.7.5 to 6.8.0

Release notes

Sourced from @​typescript-eslint/parser's releases.

v6.8.0

6.8.0 (2023-10-16)

Bug Fixes

  • eslint-plugin: [consistent-type-imports] import assertion checks added (#7722) (afdae37)
  • eslint-plugin: [no-shadow] fix static class generics for class expressions (#7724) (e5ea1d0)
  • eslint-plugin: [no-unsafe-member-access] report on only the accessed property (#7717) (f81a2da)
  • eslint-plugin: [no-useless-empty-export] exempt .d.ts (#7718) (ac397f1)

Features

  • eslint-plugin: add new extended rule prefer-destructuring (#7117) (3c6379b)

You can read about our versioning strategy and releases on our website.

Changelog

Sourced from @​typescript-eslint/parser's changelog.

6.8.0 (2023-10-16)

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

Commits

Updates nock from 13.3.3 to 13.3.4

Release notes

Sourced from nock's releases.

v13.3.4

13.3.4 (2023-10-10)

Bug Fixes

  • typescript: support nock(new URL('https://example.test/')) (#2526) (6987327)
Commits
  • 6987327 fix(typescript): support nock(new URL('https://example.test/')) (#2526)
  • feaa66f chore(deps-dev): bump prettier from 2.8.8 to 3.0.3
  • 5853b56 chore(deps-dev): bump eslint-config-prettier from 8.9.0 to 9.0.0
  • 1116433 chore(deps-dev): bump chai from 4.3.7 to 4.3.8
  • f3abae9 chore(deps-dev): bump eslint-plugin-import from 2.28.0 to 2.28.1
  • c3762c1 chore(deps-dev): bump typescript from 5.1.6 to 5.2.2
  • See full diff in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
@actions/github [>= 5.a, < 6]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the npm group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github) | `5.1.1` | `6.0.0` |
| [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) | `4.0.6` | `4.0.7` |
| [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon) | `10.0.17` | `10.0.19` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.7.5` | `6.8.0` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.7.5` | `6.8.0` |
| [nock](https://github.com/nock/nock) | `13.3.3` | `13.3.4` |


Updates `@actions/github` from 5.1.1 to 6.0.0
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/github)

Updates `@types/js-yaml` from 4.0.6 to 4.0.7
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml)

Updates `@types/sinon` from 10.0.17 to 10.0.19
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon)

Updates `@typescript-eslint/eslint-plugin` from 6.7.5 to 6.8.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.8.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 6.7.5 to 6.8.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.8.0/packages/parser)

Updates `nock` from 13.3.3 to 13.3.4
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md)
- [Commits](nock/nock@v13.3.3...v13.3.4)

---
updated-dependencies:
- dependency-name: "@actions/github"
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: npm
- dependency-name: "@types/js-yaml"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm
- dependency-name: "@types/sinon"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm
- dependency-name: nock
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the Update dependencies Trigger PR workflow to update dependencies label Oct 16, 2023
@dependabot dependabot bot requested a review from a team as a code owner October 16, 2023 17:52
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Oct 16, 2023
@github-actions
Copy link
Contributor

Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks.

@github-actions github-actions bot marked this pull request as draft October 16, 2023 17:54
@angelapwen angelapwen marked this pull request as ready for review October 16, 2023 18:15
@angelapwen angelapwen enabled auto-merge (squash) October 16, 2023 18:16
@angelapwen
Copy link
Contributor

Hm.. unit test failures seem to be real, I kicked off the workflow on main and it passes: https://github.com/github/codeql-action/actions/runs/6540153066.

cc @dbartol as 🛡️ for the next day, and then I'll be on the rotation in any case so I can come back to it if it's not resolved by Wednesday.

@henrymercer
Copy link
Contributor

Note that the major bump of @actions/github does not support Node 16 so we can't upgrade to this until v2 is deprecated.

@angelapwen angelapwen added the DO NOT MERGE This pull request should not be merged yet label Oct 17, 2023
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrymercer, blocking the PR from being merged until then!

@henrymercer
Copy link
Contributor

henrymercer commented Oct 17, 2023

I think we probably want to add version 6.0.0 of @actions/github to the ignore list and ask Dependabot to regenerate the PR, such that we can continue updating other dependencies. Once we stop supporting v2, we will be able to drop support for Node 16 at which point we can revisit the ignore list and update the dependencies.

@angelapwen
Copy link
Contributor

Oh yes, that makes sense.

@angelapwen
Copy link
Contributor

@dependabot ignore @actions/github 6.0.0

@angelapwen
Copy link
Contributor

Doesn't seem to have worked.. I'll add it to the ignore list manually 😆

@henrymercer
Copy link
Contributor

@dependabot unignore @actions/github

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 17, 2023

No dependency name (@actions/github) or ignore conditions found to unignore.

@henrymercer
Copy link
Contributor

@dependabot ignore @actions/github major version

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 17, 2023

OK, I won't notify you about version 6.x.x of @actions/github again, unless you unignore it.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 17, 2023

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Oct 17, 2023
auto-merge was automatically disabled October 17, 2023 17:47

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/npm-a4caa1cf93 branch October 17, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This pull request should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants