Show lines of code data in debug mode only #15874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new file coverage metrics are available in all supported GHES versions. This PR tags lines of code queries as telemetry queries. Lines of code information will still be available in the SARIF file, but it will no longer be displayed in the logging output of the CLI. The one exception is the metric queries for Java/Kotlin that provides separate lines of code information for Java and Kotlin. I've kept these since separate file coverage information for languages like Java and Kotlin is only available for GHES 3.12 and later.
mbg
previously approved these changes
Mar 11, 2024
henrymercer
added
the
no-change-note-required
|
I've added a changenote on the CLI side. |
geoffw0
previously approved these changes
Mar 13, 2024
RasmusWL
previously approved these changes
Mar 15, 2024
|
Based on some internal feedback, I'm going to implement a "debug" level for metric queries that means they will only show up in the analysis summary at higher verbosities, for example when running in the CodeQL Action debug mode. This lets advanced users see the lines of code information more easily, while we display only the improved and less flawed file-based coverage information by default. |
henrymercer
changed the title
henrymercer
dismissed stale reviews from RasmusWL, geoffw0, and mbg
via
a76832f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new file coverage metrics are available in all supported GHES versions. This PR tags lines of code queries as
debug. This means that lines of code information will only be shown in the logging output of the CLI when running at higher verbosities (including the CodeQL Action debug mode). Lines of code information will also still be available in the SARIF file.The one exception is the metric queries for Java/Kotlin that provides separate lines of code information for Java and Kotlin. I've left these as non-debug level since separate file coverage information for languages like Java and Kotlin is only available for GHES 3.12 and later.