Tree-sitter: Split up ast_node_info
table into two tables
#15966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DIL generated for
AstNode.getParent
is unnecessarily complex. Instead of using theast_node_info
extensional directly, we get a join withThis happens because
ast_node_info
needs to contain a row for each AST node, as it also records AST node locations, and hence the column for the parent is not simply anAstNode
, but either anAstNode
or aFile
(to account for root AST nodes). By splitting upast_node_info
into two separate extensionals,ast_node_location
andast_node_parent
, we can use theast_node_parent
extensional directly inAstNode.getParent
.The decrease in DIL size is confirmed by DCA.