Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: prepare integration tests for internal running #16034

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

redsun82
Copy link
Contributor

This harmonizes Swift integration tests with the rest of the repository, to prepare for the internal integration test runner to run them. The stripped down runner is kept compatible, so that current CI can still use it now. Maybe it will be kept for developer use.

This PR includes:

  • moving the integration tests inside ql
  • editing qlpack.yml so that the internal runner can use it
  • change database directory to be test-db rather than db

This harmonizes Swift integration tests with the rest of the repository,
to prepare for the internal integration test runner to run them. The
stripped down runner is kept compatible, so that current CI can still
use it now. Maybe it will be kept for developer use.

This PR includes:
* moving the integration tests inside `ql`
* editing `qlpack.yml` so that the internal runner can use it
* change database directory to be `test-db` rather than `db`
@github-actions github-actions bot added the Swift label Mar 25, 2024
@redsun82 redsun82 marked this pull request as ready for review March 25, 2024 12:38
@redsun82 redsun82 requested a review from a team as a code owner March 25, 2024 12:38
@redsun82 redsun82 requested a review from criemen March 25, 2024 12:38
Copy link
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@redsun82 redsun82 force-pushed the redsun82/swift-move-integration-tests-to-internal branch from ed7e1ca to 9c9f4b9 Compare March 25, 2024 12:53
@redsun82 redsun82 merged commit dea9229 into main Mar 25, 2024
38 checks passed
@redsun82 redsun82 deleted the redsun82/swift-move-integration-tests-to-internal branch March 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants