Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add missing query precision #16209

Merged
merged 2 commits into from
Apr 16, 2024
Merged

C#: Add missing query precision #16209

merged 2 commits into from
Apr 16, 2024

Conversation

joefarebrother
Copy link
Contributor

Adds precision medium to cs/web/request-validation-disabled

@joefarebrother joefarebrother added the no-change-note-required This PR does not need a change note label Apr 15, 2024
@joefarebrother joefarebrother requested a review from a team as a code owner April 15, 2024 10:01
@github-actions github-actions bot added the C# label Apr 15, 2024
michaelnebel
michaelnebel previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auch - so this wasn't part of any of the query suites really. Good catch.
Now it is a part of security extended.
Should it be part of the code scanning default?

@joefarebrother
Copy link
Contributor Author

Yes, looks like it can actually be precision: high and thus be in code scanning default.

michaelnebel
michaelnebel approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joefarebrother joefarebrother merged commit f57e0cb into github:main Apr 16, 2024
20 checks passed
@joefarebrother joefarebrother mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joefarebrother @michaelnebel