Java: Improve dispatch through TypeFlow of effectively private calls. #16561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 24 removed results in OWASP were indeed FPs, so that's a nice improvement. |
aschackmull
force-pushed
the
java/typeflow-effectively-private
branch
from
b9bd2ce
to
b519f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves TypeFlow to account for more argument-parameter pairs. Previously this was restricted to private callables, as we need to ensure that a proper closed-world assumption applies, since we're doing a universal flow calculation, but this can be extended to all callables that aren't implicitly public.
Improved TypeFlow means improved virtual dispatch, which ought to translate to more precise data flow.